Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): change MAX_COMMIT_SCALAR and MAX_BLOB_SCALAR to 1e18 #1354

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

zimpha
Copy link
Member

@zimpha zimpha commented May 31, 2024

Purpose or design rationale of this PR

This PR change the value of MAX_COMMIT_SCALAR and MAX_BLOB_SCALAR to 1e18, since we are sure they won't have larger values.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.30%. Comparing base (ba77a74) to head (e3e9d75).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1354   +/-   ##
========================================
  Coverage    54.30%   54.30%           
========================================
  Files          156      156           
  Lines        11922    11922           
========================================
  Hits          6474     6474           
  Misses        4953     4953           
  Partials       495      495           
Flag Coverage Δ
contracts 56.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thegaram Thegaram requested a review from icemelon May 31, 2024 10:18
@zimpha zimpha merged commit f12e8e3 into develop Jun 1, 2024
4 checks passed
@zimpha zimpha deleted the feat/adjust_bound_of_scalars branch June 1, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants