Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollup-relayer): make chunk & batch proposal intervals configurable #1459

Merged

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Jul 19, 2024

Purpose or design rationale of this PR

This PR makes chunk & batch proposal intervals configurable.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

rollup/conf/config.json Outdated Show resolved Hide resolved
@colinlyguo colinlyguo changed the title feat(rollup-relayer): make chunk & batch proposal time configurable feat(rollup-relayer): make chunk & batch proposal intervals configurable Jul 19, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.29%. Comparing base (bfb3c7d) to head (538d7f2).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1459   +/-   ##
========================================
  Coverage    53.29%   53.29%           
========================================
  Files          155      155           
  Lines        11770    11770           
========================================
  Hits          6273     6273           
  Misses        5002     5002           
  Partials       495      495           
Flag Coverage Δ
rollup 56.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinlyguo colinlyguo merged commit 0fd7a87 into develop Jul 19, 2024
5 checks passed
@colinlyguo colinlyguo deleted the feat-make-chunking-and-batching-loop-time-configurable branch July 19, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants