Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(libzkp): different paths for assets of lower and higher versions #1461

Merged
merged 5 commits into from
Jul 26, 2024

Conversation

roynalnaruto
Copy link
Contributor

chunk verifier v3 and v4 needs different assets path to be initialised

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.67%. Comparing base (82f39aa) to head (61032c9).

Additional details and impacted files
@@              Coverage Diff               @@
##           feat/upgrade4    #1461   +/-   ##
==============================================
  Coverage          52.67%   52.67%           
==============================================
  Files                157      157           
  Lines              12527    12527           
==============================================
  Hits                6599     6599           
  Misses              5367     5367           
  Partials             561      561           
Flag Coverage Δ
common 49.61% <ø> (ø)
coordinator 17.53% <ø> (ø)
database 42.85% <ø> (ø)
rollup 57.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgehao georgehao changed the title different paths for assets of v3 and v4 feat(libzkp): different paths for assets of v3 and v4 Jul 22, 2024
@roynalnaruto roynalnaruto changed the title feat(libzkp): different paths for assets of v3 and v4 feat(libzkp): different paths for assets of lower and higher versions Jul 22, 2024
@georgehao georgehao merged commit f1fae1f into feat/upgrade4 Jul 26, 2024
13 checks passed
@georgehao georgehao deleted the fix/chunk-verifier-v3-v4-assets-path branch July 26, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants