Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup libzkp interfaces used by coordinator and update da-codec dependency #1469

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Jul 30, 2024

Purpose or design rationale of this PR

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.57%. Comparing base (d2ff088) to head (38f926b).

Additional details and impacted files
@@                Coverage Diff                @@
##           feat/upgrade4    #1469      +/-   ##
=================================================
- Coverage          52.65%   52.57%   -0.09%     
=================================================
  Files                157      156       -1     
  Lines              12531    12444      -87     
=================================================
- Hits                6598     6542      -56     
+ Misses              5372     5341      -31     
  Partials             561      561              
Flag Coverage Δ
bridge-history-api 71.16% <ø> (ø)
common 47.35% <ø> (-1.89%) ⬇️
coordinator 17.53% <ø> (ø)
database 42.85% <ø> (ø)
rollup 57.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@amoylan2 amoylan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinlyguo colinlyguo merged commit a22aa8d into feat/upgrade4 Jul 30, 2024
16 checks passed
@colinlyguo colinlyguo deleted the refactor-cleanup branch July 30, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants