Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coordinator): add blob bytes in batch proving task #1485

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Aug 18, 2024

Purpose or design rationale of this PR

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 3.07692% with 63 lines in your changes missing coverage. Please review.

Project coverage is 52.01%. Comparing base (50a5b26) to head (361d1fa).

Files Patch % Lines
coordinator/internal/orm/l2_block.go 0.00% 35 Missing ⚠️
coordinator/cmd/api/app/mock_app.go 0.00% 16 Missing ⚠️
coordinator/internal/orm/batch.go 0.00% 10 Missing ⚠️
rollup/internal/utils/utils.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           feat-rollup-relayer-codecv4    #1485      +/-   ##
===============================================================
- Coverage                        52.09%   52.01%   -0.08%     
===============================================================
  Files                              156      156              
  Lines                            12664    12684      +20     
===============================================================
+ Hits                              6597     6598       +1     
- Misses                            5501     5520      +19     
  Partials                           566      566              
Flag Coverage Δ
common 47.35% <ø> (ø)
coordinator 17.20% <1.61%> (-0.20%) ⬇️
database 42.85% <ø> (ø)
rollup 55.68% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinlyguo colinlyguo merged commit a25b848 into feat-rollup-relayer-codecv4 Aug 23, 2024
17 checks passed
@colinlyguo colinlyguo deleted the feat-coordinator-add-blob-bytes-in-batch-proving-task branch August 23, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants