Correct source of entropy

scroll-tech · Sep 18, 2024 · dd9159f · dd9159f
1 parent 8813d53
commit dd9159f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/aggregator/src/mock_chunk.rs b/aggregator/src/mock_chunk.rs
@@ -9,6 +9,7 @@ use snark_verifier::loader::halo2::halo2_ecc::halo2_base::SKIP_FIRST_PASS;
 use snark_verifier_sdk::CircuitExt;
 use std::iter;
 use zkevm_circuits::{table::KeccakTable, util::Challenges};
+use rand::RngCore;
 
 use crate::{
     constants::{ACC_LEN, DIGEST_LEN},
@@ -49,8 +50,8 @@ impl MockChunkCircuit {
 }
 
 impl MockChunkCircuit {
-    pub fn random<R: rand::RngCore>(r: &mut R, has_accumulator: bool, is_padding: bool) -> Self {
-        let chunk = ChunkInfo::mock_random_chunk_info_for_testing(r);
+    pub fn random<R: RngCore>(mut r: R, has_accumulator: bool, is_padding: bool) -> Self {
+        let chunk = ChunkInfo::mock_random_chunk_info_for_testing(&mut r);
         Self {
             has_accumulator,
             chunk: if is_padding {

diff --git a/compression/src/tests.rs b/compression/src/tests.rs
@@ -205,7 +205,7 @@ fn test_mock_compression() {
     let params_app = gen_srs(k0);
 
     let mut rng = test_rng();
-    let circuit = MockChunkCircuit::random(&mut rng, false, false);
+    let circuit = MockChunkCircuit::random(OsRng, false, false);
 
     let pk = gen_pk(&params_app, &circuit, None);
     let snark = gen_snark_shplonk(&params_app, &pk, circuit, None::<&str>);