Added spoolman metrics #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also use Spoolman with my Klipper install so I will give this a test and provide any feedback. |
|
I have already do PR to Spoolman with simillar feature. For both it view as: 
|
type mismatch
scross01
requested changes
Apr 14, 2024
There was a problem hiding this comment.
- Add comments where highlighted for consistency
- Add
spoolmanentry in example configexample/prometheus.yml - Update the table with the list of supported metrics in the Modules section of README.md
- I suggest adding a short section in the README.md specifically covering how the klipper spoolman metrics can be used in conjunction with the spoolman metrics (Added prometheus integration Donkie/Spoolman#350)
| @@ -34,6 +35,13 @@ func getValidLabelName(str string) string { | |||
| return prometheusMetricNameInvalidCharactersRegex.ReplaceAllString(strings.Replace(str, "-", "_", -1), "") | |||
| } | |||
|
|
|||
| func b2f(cond bool) float64 { | |||
There was a problem hiding this comment.
Add a comment before the function definition to explain its purpose (i.e. convert bool to float value)
| @@ -533,6 +541,23 @@ func (c Collector) Collect(ch chan<- prometheus.Metric) { | |||
| pinName) | |||
| } | |||
| } | |||
|
|
|||
| if slices.Contains(c.modules, "spoolman") { | |||
There was a problem hiding this comment.
Add a comment line // Spoolman for consistency to other code sections above
| @@ -0,0 +1,55 @@ | |||
| package collector | |||
|
|
|||
There was a problem hiding this comment.
Add a comment with a link to the relevant section of the moonraker docs
i.e. // https://moonraker.readthedocs.io/en/latest/web_api/#spoolman-apis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added metrics from Spoolman module, such as current spool ID and connected status&