Make UncheckedExtrinsicV4 generic #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haerdib
added
F7-enhancement
haerdib
changed the title
haerdib
changed the title
haerdib
force-pushed
the
bh/generic-unchecked-extrinsic
branch
3 times, most recently
from
7090df1 to
da78380
Compare
Niederb
approved these changes
Jan 10, 2023
|
|
||
| let recipient = AccountKeyring::Bob.to_account_id(); | ||
| let recipient: <MyExtrinsicSigner as SignExtrinsic<AccountId>>::ExtrinsicAddress = |
There was a problem hiding this comment.
As discussed: I'm a bit confused by this syntax. I would expect that the as ... part is not neccessary
There was a problem hiding this comment.
Sadly it is:
error[E0223]: ambiguous associated type
--> examples/examples/benchmark_bulk_xt.rs:43:17
|
43 | let recipient: MyExtrinsicSigner::ExtrinsicAddress = AccountKeyring::Bob.to_account_id().into();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use fully-qualified syntax: `<ExtrinsicSigner<sp_core::sr25519::Pair, MultiSignature, kitchensink_runtime::Runtime> as Trait>::ExtrinsicAddress`But let me define a better type for that.
There was a problem hiding this comment.
I'm guessing it's because of the trait type AccountId which needs to be defined.
clangenb
reviewed
Jan 10, 2023
testing/examples/author_tests.rs
Outdated
Comment on lines
47
to
50
| let bob: ExtrinsicAddressOf<ExtrinsicSigner> = AccountKeyring::Bob.to_account_id().into(); | ||
|
|
||
| // Submit extrinisc. | ||
| let xt0 = api.balance_transfer(bob.clone(), 1000); | ||
| let xt0 = api.balance_transfer(bob.clone().into(), 1000); |
There was a problem hiding this comment.
You have double into here. You can remove the annoying type annotation if you just remove the first one.
There was a problem hiding this comment.
Good catch! I removed the second one, though, because the .into() would need to be repeated up to 6 times afterwards.
wohoo fix most finally compiling make clippy happy remove unused comment update comment Fix documentation for running an example (#417) Also some minor typos clean up imports of macors Remove thiserror and use more specific Error names (#419) * small result clean up * lets not overcomplicate * remove thiserror * remove unused errors fix build Bump tokio from 1.23.0 to 1.23.1 (#427) Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.23.0 to 1.23.1. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.23.0...tokio-1.23.1) --- updated-dependencies: - dependency-name: tokio dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
haerdib
force-pushed
the
bh/generic-unchecked-extrinsic
branch
from
897f5be to
438fe00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UncheckedExtrinsicis now generic over the AccountId, Signer and Address type. All types of substrate nodes should now be supported, no matter which Account types are used.SignExtrinsictrait to simplify theAddress,AccountIdandSignatureallocation as much as possible.ExtrinsicSignershould be usable for most use cases, except for when noRuntimeis used. In that case one still has to option to implement the trait oneselves.UncheckedExtrinsicnow implements anew_unsignedfunction.Drawback:
Signaturetype needs to be defined explicitly. However, #406 may help with that.closes #360