Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to newest substrate #479

Merged
merged 7 commits into from
Mar 29, 2023
Merged

update to newest substrate #479

merged 7 commits into from
Mar 29, 2023

Conversation

echevrier
Copy link
Contributor

@echevrier echevrier commented Mar 22, 2023 •
edited
Loading

@echevrier echevrier requested a review from haerdib March 22, 2023 16:39
@echevrier echevrier added E1-breaksnothing F9-dependencies Pull requests that update a dependency file labels Mar 22, 2023
haerdib
haerdib reviewed Mar 29, 2023
View reviewed changes
Copy link
Contributor

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for the fix!

examples/examples/event_error_details.rs Outdated
// We expect a TokenError::FundsUnavailable error. See :
//https://github.com/paritytech/substrate/blob/b42a687c9050cbe04849c45b0c5ccadb82c84948/frame/support/src/traits/tokens/fungible/mod.rs#L177
assert!(string_error.contains("Other"));
assert!(string_error.contains("[7, 0, 194, 110, 3, 65, 37, 56, 0, 0]")); //This is for now not decoded. See issue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the issue number and a FIXME?

@haerdib haerdib requested a review from Niederb March 29, 2023 10:01
Niederb
Niederb approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@Niederb Niederb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems you always get the nasty upgrades 😆
On the plus side the cargo update fixed #474 (remove_dir_all is not in the Cargo.lock anymore)

@echevrier echevrier requested a review from haerdib March 29, 2023 11:15
haerdib
haerdib approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@haerdib haerdib linked an issue Mar 29, 2023 that may be closed by this pull request
Fix security issue of dependabot #474
Closed
@echevrier echevrier merged commit 08f3f6c into master Mar 29, 2023
@haerdib haerdib linked an issue Mar 29, 2023 that may be closed by this pull request
Upgrade to newest substrate master commit #481
Closed
@echevrier echevrier deleted the ec/updateto_newest_substrate branch April 18, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Niederb Niederb Niederb approved these changes

@haerdib haerdib haerdib approved these changes

Assignees
No one assigned
Labels
E1-breaksnothing F9-dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to newest substrate master commit Fix security issue of dependabot
3 participants
@echevrier @Niederb @haerdib