Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Udpate toml versions for tag v0.11.0 #515

Merged
merged 4 commits into from
Apr 5, 2023
Merged

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Apr 4, 2023

Changes can be looked up here: v0.10.0...v0.11.0

Summary:

  • api-client: ⚡ Contains breaking changes due to function renaming and pub re-exports removals.
  • client-keystore: ⚡ Breaking changes due to substrate update
  • compose-macros: ⚡ Breaking changes due to pub use rpc::* removal
  • examples: ⚡ follow the breaking changes of substrate
  • node-api: ⚡ breaking changes due to more restrictive public re-export
  • primitives: ⚡ breaking changes due to more restrictive public re-export and file moving
  • testing: ⚡ follow the breaking changes of substrate

@haerdib haerdib added the E0-silent Will not be mentioned in the release label Apr 4, 2023
@haerdib haerdib self-assigned this Apr 4, 2023
@haerdib haerdib requested a review from masapr April 4, 2023 14:34
@haerdib haerdib requested a review from Niederb April 5, 2023 07:21
Copy link
Collaborator

@masapr masapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@Niederb Niederb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the removal of pub use rpc::*; in compose-macros/src/lib.rs a breaking change as well?
I recently saw this cargo-semver-checks maybe this would make it easier to identify breaking changes. I haven't tried it though.

@haerdib
Copy link
Contributor Author

haerdib commented Apr 5, 2023

Yes, you're right. I'll adapt

@haerdib haerdib requested a review from Niederb April 5, 2023 09:50
@haerdib haerdib merged commit c82bc0b into master Apr 5, 2023
@haerdib haerdib deleted the bh/prepare-tag-v0.11.0 branch April 5, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E0-silent Will not be mentioned in the release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants