Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change generic types of traits to associated types #534

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Change generic types of traits to associated types #534

merged 1 commit into from
Apr 13, 2023

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Apr 13, 2023 •
edited
Loading

closes #533

@haerdib haerdib self-assigned this Apr 13, 2023
@haerdib haerdib marked this pull request as ready for review April 13, 2023 11:06
@haerdib haerdib requested review from Niederb and echevrier April 13, 2023 11:06
echevrier
echevrier approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@echevrier echevrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. This makes sense.
Thanks

Niederb
Niederb approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@Niederb Niederb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😸

@haerdib haerdib merged commit 6d09a9d into master Apr 13, 2023
@haerdib haerdib deleted the bh/remove-generic branch April 13, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echevrier echevrier echevrier approved these changes

@Niederb Niederb Niederb approved these changes

Assignees

@haerdib haerdib

Labels
E2-breaksapi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not use generic when not needed in traits
3 participants
@haerdib @Niederb @echevrier