Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document feature flags #558

Merged
merged 3 commits into from
May 2, 2023
Merged

Document feature flags #558

merged 3 commits into from
May 2, 2023

Conversation

Niederb
Copy link
Contributor

@Niederb Niederb commented Apr 28, 2023

Closes #526

Copy link
Contributor

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a lot!

# Use the `tungstenite` crate for websocket communication. No async support but has some reconnection capabilities.
tungstenite-client = ["std", "tungstenite"]
# Use the `ws` crate for websocket communication. No async support.
# Establishes a new connection for each request and therefore is limited in terms of performance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I like this documentation very much. Your example linking below just gave me the idea: Would it make sense to link to the ws_client example as well? (same for tungestenite)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I added the examples to the documentation.

@Niederb Niederb force-pushed the tn/document-feature-flag branch from 74b9c0b to 1b24d01 Compare May 2, 2023 07:41
@Niederb Niederb merged commit 9625c87 into master May 2, 2023
@Niederb Niederb deleted the tn/document-feature-flag branch July 17, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for rpc-client / features import
2 participants