Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add storage_double_map_key_prefix #568

Merged
merged 4 commits into from
May 23, 2023
Merged

add storage_double_map_key_prefix #568

merged 4 commits into from
May 23, 2023

Conversation

BurnWW
Copy link
Contributor

@BurnWW BurnWW commented May 5, 2023

No description provided.

@haerdib haerdib added F7-enhancement Enhances an already existing functionality E1-breaksnothing labels May 8, 2023
@haerdib
Copy link
Contributor

haerdib commented May 8, 2023

Thank you very much for the update! There's a Clippy warning now, though:

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> node-api/src/storage.rs:167:34
    |
167 |                 bytes.extend(key_hash(&key1, &hasher1));
    |                                              ^^^^^^^^ help: change this to: `hasher1`
    |

haerdib
haerdib approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the contribution!

src/rpc/jsonrpsee_client/mod.rs
@@ -42,7 +42,7 @@ impl JsonrpseeClient {
Self::new("ws://127.0.0.1:9944")
}

async fn async_new(url: &str) -> Result<Self> {
pub async fn async_new(url: &str) -> Result<Self> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely, thanks !

@haerdib haerdib merged commit a887097 into scs:master May 23, 2023
haerdib pushed a commit that referenced this pull request Jun 14, 2023
@BurnWW @haerdib
Add storage_double_map_key_prefix (#568)
d17eb33 
* add storage_double_map_key_prefix

* fixe haser error

* Update mod.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haerdib haerdib haerdib approved these changes

Assignees
No one assigned
Labels
E1-breaksnothing F7-enhancement Enhances an already existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BurnWW @haerdib