Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move get_system_account_next_index to GetAccountInformation #575

Merged
merged 2 commits into from
May 15, 2023
Merged

Move get_system_account_next_index to GetAccountInformation #575

merged 2 commits into from
May 15, 2023

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented May 15, 2023

Only realized after merging #573 , but I believe get_system_account_next_index fits better to GetAccountInformation. This way, index and AccountId do not need to be redefined for trait SystemApi.

@haerdib haerdib self-assigned this May 15, 2023
@haerdib haerdib requested review from echevrier and Niederb May 15, 2023 08:44
Niederb
Niederb approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@Niederb Niederb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Makes more sense in GetAccountInformation

echevrier
echevrier approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@echevrier echevrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

@haerdib haerdib marked this pull request as ready for review May 15, 2023 09:23
@haerdib haerdib added F7-enhancement Enhances an already existing functionality E2-breaksapi labels May 15, 2023
@haerdib haerdib merged commit 15a0a6f into master May 15, 2023
@haerdib haerdib deleted the bh/move-get-account-next-index branch May 15, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echevrier echevrier echevrier approved these changes

@Niederb Niederb Niederb approved these changes

Assignees

@haerdib haerdib

Labels
E2-breaksapi F7-enhancement Enhances an already existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haerdib @Niederb @echevrier