Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rpc-api author: Clarify comments about blocking functions #679

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Rpc-api author: Clarify comments about blocking functions #679

merged 2 commits into from
Nov 28, 2023

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Nov 28, 2023 •
edited
Loading

closes #665

@haerdib haerdib self-assigned this Nov 28, 2023
@haerdib haerdib marked this pull request as ready for review November 28, 2023 07:40
@haerdib haerdib requested a review from masapr November 28, 2023 07:40
@haerdib haerdib added E1-breaksnothing F4-documentation Updates the documentation labels Nov 28, 2023
@haerdib haerdib merged commit bec07d4 into master Nov 28, 2023
45 of 46 checks passed
@haerdib haerdib deleted the bh/665-remove-wrong-comments branch November 28, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masapr masapr masapr approved these changes

Assignees

@haerdib haerdib

Labels
E1-breaksnothing F4-documentation Updates the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix /// This method is blocking. comments
2 participants
@haerdib @masapr