Remove sync api jsonrpsee #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haerdib
commented
Jan 29, 2024
node-api/src/error/mod.rs
Outdated
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| //! General node-api Error implementation. | |||
|
|
|||
| use alloc::{string::String, vec::Vec}; | |||
| use alloc::{boxed::Box, string::String, vec::Vec}; | |||
There was a problem hiding this comment.
Clippy warning - error was too long for being unconstrained.
| @@ -30,58 +30,6 @@ use sp_version::RuntimeVersion; | |||
| /// Api to talk with substrate-nodes | |||
| /// | |||
| /// It is generic over the `Request` trait, so you can use any rpc-backend you like. | |||
| /// | |||
| /// # Custom Client Example | |||
There was a problem hiding this comment.
Removed the custom client example, because it was not easily possible to make it compile for both sync and async features and is already described in the README https://github.com/scs/substrate-api-client#rpc-client
haerdib
force-pushed
the
bh/remove-sync-api-jsonrpsee
branch
2 times, most recently
from
6e512a8 to
16109de
Compare
fix tests update ci cargo fmt fix compile error fix clippy remove compile error and ensure jsonrpsee is only exported when not sync api clean up dependencies move keystore_tests.rs to sync examples update .lock remove unneeded deps clean up sync example toml clean up async example toml remove sync part from async exmaple speed up example add box around dynamic error values readd spacing use async code smart speed up example make author_test actually async add sleep add some sleeps to avoid future error remove obsolete async naming update README update README update CI
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As decided in #692, this PR removes the sync interface for the jsonrpsee client. Because now not all feauters are compatible with each other anymore (jsonrpsee may not be built with sync interface), the examples were split up between sync and async. This allows to distinguish the build and test them separately.
The following has been changed:
- changed jsonrpsee examples to purely async ones
- moved ws und tungstentite examples to the sync folder since they officially only support sync.
- removed futures from jsonrpsee because tokio should be used instead for consistency
block_onbecause the default version is async. Since the api behind it is a dummy client, block_on should be fine.closes #692