Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failed extrinsic error #725

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Add failed extrinsic error #725

merged 3 commits into from
Feb 22, 2024

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Feb 19, 2024

When an extrinsic fails onchain, the full encoded report is now returned. This allows the user to retrieve the associated events, blockhash and the dispatch error.

closes #617

@haerdib haerdib self-assigned this Feb 19, 2024
@haerdib haerdib marked this pull request as ready for review February 22, 2024 12:49
@haerdib haerdib requested a review from masapr February 22, 2024 12:49
@haerdib haerdib added F7-enhancement Enhances an already existing functionality E2-breaksapi labels Feb 22, 2024
Copy link
Collaborator

@masapr masapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@haerdib haerdib merged commit 303eaa9 into master Feb 22, 2024
58 of 59 checks passed
@haerdib haerdib deleted the bh/617-return-encoded-xt-info branch February 22, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2-breaksapi F7-enhancement Enhances an already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return full extrinsic information, even when xt has failed
2 participants