Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump toml versions #729

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Bump toml versions #729

merged 1 commit into from
Feb 26, 2024

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Feb 23, 2024

Updates the following tomls:

related to #726

@haerdib haerdib self-assigned this Feb 23, 2024
@haerdib haerdib added E1-breaksnothing F9-dependencies Pull requests that update a dependency file labels Feb 23, 2024
@haerdib haerdib changed the title Update tomls for new release Bump toml versions Feb 23, 2024
@haerdib haerdib marked this pull request as ready for review February 23, 2024 13:48
@haerdib haerdib requested a review from masapr February 23, 2024 13:48
Copy link
Collaborator

@masapr masapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, it's good practice to have different versions for different packages. Couldn't we put all packages to 0.17.0 ?

@haerdib
Copy link
Contributor Author

haerdib commented Feb 26, 2024

We could, but how can we track breaking changes for the different crates then? AFAIK it is not common in rust to have one version for all crates.

@masapr
Copy link
Collaborator

masapr commented Feb 26, 2024

I'm not saying we should have one version for all crates. I'm just saying, that at this point, we could set it to the same version number. Then, when we have minor changes, we can still have differences in the last digit behind the last dot.
... but might be better to continue the way we've done it in the past, so that it stays consistent

@haerdib haerdib merged commit 9f550f6 into master Feb 26, 2024
59 checks passed
@haerdib haerdib deleted the bh/update-tomls branch February 26, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E1-breaksnothing F9-dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants