Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contracts extrinsic #737

Merged
merged 7 commits into from
Feb 29, 2024
Merged

Update contracts extrinsic #737

merged 7 commits into from
Feb 29, 2024

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Feb 27, 2024

This PR updates the pallet contracts and moves the example to tests instead, as it is not complete for now. This needs to be done in a follow-up issue: #738

closes #435

@haerdib haerdib self-assigned this Feb 27, 2024
@haerdib haerdib marked this pull request as ready for review February 29, 2024 13:29
@haerdib haerdib added E1-breaksnothing F9-dependencies Pull requests that update a dependency file labels Feb 29, 2024
@haerdib haerdib requested a review from masapr February 29, 2024 13:31
@masapr
Copy link
Collaborator

masapr commented Feb 29, 2024

If the example isn't working. Why can it run as a green test?

@haerdib
Copy link
Contributor Author

haerdib commented Feb 29, 2024

Sorry, updated the text. The "not working" was for the old example.

Copy link
Collaborator

@masapr masapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@haerdib haerdib merged commit f87ed2b into master Feb 29, 2024
58 checks passed
@haerdib haerdib deleted the bh/435-update-contracts branch February 29, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E1-breaksnothing F9-dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update contracts module and add example to CI
2 participants