Flag to disable metadata hash check #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deactivate two tests for now
- Add feature to the main Cargo.toml
masapr
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains the minimal changes needed to support the new extrinsic format with metadata-hash but actually disables the check.
We should discuss how/if we want to support this kind of breaking change by supporting backwards compatibility. In theory we would need to run the whole testing pipeline for both versions and for some cases we would need separate test-data. Already in this PR I had to deactivate two tests as the data is not compatible anymore (and I have honestly no idea how the file
test-runtime.compact.wasmwas generated)