Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Rotten Tomatoes page for Soul links to the wrong movie #494

Closed
ctrlaltd1337ed opened this issue Dec 25, 2020 · 3 comments
Closed

The Rotten Tomatoes page for Soul links to the wrong movie #494

ctrlaltd1337ed opened this issue Dec 25, 2020 · 3 comments

Comments

@ctrlaltd1337ed
Copy link

ctrlaltd1337ed commented Dec 25, 2020

Describe the bug
Incorrect Rotten Tomatoes page is linked in the Soul movie.

What version of Overseerr are you running?
Develop, but I last upgraded when 1.13 was released

To Reproduce
Open the "Soul" movie page and click on the Rotten Tomatoes link.

Expected behavior
The "Soul" Rotten Tomatoes page.

Smartphone (please complete the following information):

  • Device: Pixel 4XL
  • OS: Android 11
  • Browser: Chrome
  • Version: 87.0.4280.101

Additional context
Links to https://www.rottentomatoes.com/m/mr_soul

@danshilm
Copy link
Collaborator

This seems to be a limitation of the Rotten Tomatoes API used

/**
* This is a best-effort API. The Rotten Tomatoes API is technically
* private and getting access costs money/requires approval.
*
* They do, however, have a "public" api that they use to request the
* data on their own site. We use this to get ratings for movies/tv shows.
*
* Unfortunately, we need to do it by searching for the movie name, so it's
* not always accurate.
*/

@sct
Copy link
Owner

sct commented Dec 26, 2020

This seems to be a limitation of the Rotten Tomatoes API used

/**
* This is a best-effort API. The Rotten Tomatoes API is technically
* private and getting access costs money/requires approval.
*
* They do, however, have a "public" api that they use to request the
* data on their own site. We use this to get ratings for movies/tv shows.
*
* Unfortunately, we need to do it by searching for the movie name, so it's
* not always accurate.
*/

Correct. The matching is best effort. Two movies with the same release year and nearly same name. We can do some refinements to the matching in the RT search results to try and avoid this. But I will need to think about how.

@github-actions
Copy link

🎉 This issue has been resolved in version 1.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants