Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: specify files/directories to exclude from git archives #2184

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

TheCatLady
Copy link
Collaborator

@TheCatLady TheCatLady commented Oct 10, 2021

Description

@hotio and @linuxserver (and perhaps others) build and publish third-party Overseerr images from tarballs created by git archive.

Currently, these archives contain files that aren't necessary to build Overseerr and shouldn't be included in final, built images. This PR specifies these files/directories to be excluded in .gitattributes.

Screenshot (if UI-related)

N/A

To-Dos

N/A

Issues Fixed or Closed

N/A

@TheCatLady TheCatLady requested a review from sct as a code owner October 10, 2021 15:42
@TheCatLady TheCatLady force-pushed the chore/gitattributes branch 3 times, most recently from 4b2604d to 447c0ef Compare October 11, 2021 01:55
@TheCatLady TheCatLady force-pushed the chore/gitattributes branch 5 times, most recently from 65a94de to c5f5bb0 Compare October 18, 2021 15:27
@TheCatLady TheCatLady force-pushed the chore/gitattributes branch 2 times, most recently from 7309f48 to 50e6b07 Compare October 26, 2021 21:17
@TheCatLady TheCatLady force-pushed the chore/gitattributes branch 5 times, most recently from 7772319 to 26ff360 Compare January 20, 2022 14:01
@TheCatLady TheCatLady force-pushed the chore/gitattributes branch from b2cd916 to 255a926 Compare March 12, 2022 23:33
@TheCatLady TheCatLady requested a review from danshilm as a code owner March 12, 2022 23:33
@TheCatLady TheCatLady force-pushed the chore/gitattributes branch from 255a926 to 1344bb5 Compare March 14, 2022 19:14
@stale

This comment was marked as resolved.

@stale stale bot added the stale label May 25, 2022
@stale stale bot closed this Jun 4, 2022
@danshilm danshilm reopened this Jun 5, 2022
@stale stale bot removed the stale label Jun 5, 2022
@TheCatLady TheCatLady force-pushed the chore/gitattributes branch from 1344bb5 to 4f517c2 Compare July 4, 2022 02:29
@stale

This comment was marked as outdated.

@stale stale bot added the stale label Sep 4, 2022
@stale stale bot closed this Sep 16, 2022
@danshilm danshilm removed the stale label May 1, 2023
@danshilm danshilm reopened this May 1, 2023
@cypress
Copy link

cypress bot commented May 1, 2023

2 flaky tests on run #2125 ↗︎

0 28 0 0 Flakiness 2

Details:

chore: specify files/directories to exclude from git archives
Project: overseerr Commit: 1fa2343e75
Status: Passed Duration: 04:19 💡
Started: Oct 16, 2023 4:57 PM Ended: Oct 16, 2023 5:01 PM
Flakiness  settings/discover-customization.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Discover Customization > can create a new discover option and remove it Output Screenshots Video
Flakiness  user/profile.cy.ts • 1 flaky test

View Output Video

Test Artifacts
User Profile > loads plex watchlist Output Screenshots Video

Review all test suite changes for PR #2184 ↗︎

@stale

This comment was marked as resolved.

@stale stale bot added the stale label Jul 15, 2023
@danshilm danshilm removed the stale label Jul 16, 2023
@stale

This comment was marked as resolved.

@stale stale bot added the stale label Sep 16, 2023
@stale stale bot closed this Oct 15, 2023
@danshilm danshilm removed the stale label Oct 15, 2023
@danshilm danshilm reopened this Oct 15, 2023
@danshilm danshilm requested a review from OwsleyJr as a code owner October 15, 2023 17:23
@danshilm danshilm force-pushed the chore/gitattributes branch from 67fa6d6 to ca44a81 Compare October 16, 2023 16:37
For some reason those unformatted files are failing the lint check action, despite those files being ignored in prettier.
@danshilm danshilm enabled auto-merge (squash) October 16, 2023 16:58
@danshilm danshilm merged commit e2771a3 into develop Oct 16, 2023
6 checks passed
@danshilm danshilm deleted the chore/gitattributes branch October 16, 2023 17:02
lenaxia pushed a commit to lenaxia/overseerr-oidc that referenced this pull request Jan 3, 2024
Co-authored-by: Danshil Kokil Mungur <me@danshilm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants