Update SameSite policy of session cookie to Lax #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiRigal
requested review from
sct,
TheCatLady,
danshilm and
OwsleyJr
as code owners
|
I haven't taken the time to look into fixing the issue, so thanks for doing this. Since this is a security-related issue, I do think it makes sense to put this change behind having CSRF protection off. And then keep it Strict if CSRF protection is on. |
|
Thank you for the fast feedback @sct ! I've updated the PR to set the |
|
@all-contributors please add @RemiRigal for code |
|
I've put up a pull request to add @RemiRigal! 🎉 |
samicrusader
pushed a commit
to angelicdust/oversneedrr
that referenced
this pull request
Nov 7, 2023
* update session cookie samesite policy to lax * set cookie samesite policy based on csrf protection setting
lenaxia
pushed a commit
to lenaxia/overseerr-oidc
that referenced
this pull request
Jan 3, 2024
* update session cookie samesite policy to lax * set cookie samesite policy based on csrf protection setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The session cookie
connect.sidcurrently has aStrictSameSitepolicy, which prevents users to access pages from an external link. Requests with an externalReferrerare systematically redirected to the login page because the session cookie is not added to the request. Changing this policy will not add vulnerabilities to the application.Also, an alternative would be to set this policy to
Laxonly when the theCSRF Protectionis disabled, let me know if this is preferable.To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed