Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speed up draw speed by drawing a subset of category on load #54

Merged
merged 3 commits into from
Apr 13, 2018

Conversation

scttcper
Copy link
Owner

@scttcper scttcper commented Apr 13, 2018

fixes #51

fix: clears search on anchor click

@codecov
Copy link

codecov bot commented Apr 13, 2018

Codecov Report

Merging #54 into master will increase coverage by 0.56%.
The diff coverage is 32.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   65.58%   66.14%   +0.56%     
==========================================
  Files          22       22              
  Lines         767      768       +1     
  Branches      144      138       -6     
==========================================
+ Hits          503      508       +5     
+ Misses        208      203       -5     
- Partials       56       57       +1
Impacted Files Coverage Δ
src/lib/picker/anchors.component.ts 92.85% <100%> (+1.19%) ⬆️
src/lib/emoji/emoji.component.ts 56% <22.22%> (-3.75%) ⬇️
src/lib/picker/picker.component.ts 44.72% <29.41%> (+3.22%) ⬆️
src/lib/picker/category.component.ts 77.77% <50%> (ø) ⬆️
src/lib/picker/search.component.ts 76.92% <50%> (-2.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 249ffba...eb08a0c. Read the comment docs.

@scttcper scttcper merged commit a29514d into master Apr 13, 2018
@scttcper scttcper deleted the next branch April 13, 2018 17:13
scttcper added a commit that referenced this pull request Apr 13, 2018
* master:
  feat: speed up draw speed by drawing a subset of category on load (#54)
  chore(deps): update dependency bootstrap to v4.1.0 (#47)
  chore(deps): update dependency semantic-release to v15.1.7
  chore(deps): update dependency rxjs to v5.5.10

# Conflicts:
#	src/lib/picker/picker.component.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocking UI when open in modal
1 participant