Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Test if active before reducing number of active toasts #922 #926

Merged
merged 1 commit into from
Apr 5, 2022
Merged

fix: Test if active before reducing number of active toasts #922 #926

merged 1 commit into from
Apr 5, 2022

Conversation

TimJ0212
Copy link
Contributor

@TimJ0212 TimJ0212 commented Apr 5, 2022

fixes #922

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #926 (1827964) into master (6994d25) will decrease coverage by 0.89%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
- Coverage   55.88%   54.99%   -0.90%     
==========================================
  Files          19       19              
  Lines         510      511       +1     
  Branches       88       89       +1     
==========================================
- Hits          285      281       -4     
- Misses        216      218       +2     
- Partials        9       12       +3     
Impacted Files Coverage Δ
src/lib/toastr/toastr.service.ts 46.87% <0.00%> (-3.66%) ⬇️
src/app/home/home.component.ts 58.57% <0.00%> (-1.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6994d25...1827964. Read the comment docs.

@scttcper scttcper changed the title #922 Test if active before reducing the number of active toasts. fix: Test if active before reducing the number of active toasts #922 Apr 5, 2022
@scttcper scttcper changed the title fix: Test if active before reducing the number of active toasts #922 fix: Test if active before reducing number of active toasts #922 Apr 5, 2022
@scttcper scttcper merged commit 1d96d32 into scttcper:master Apr 5, 2022
@scttcper
Copy link
Owner

scttcper commented Apr 5, 2022

🎉 This PR is included in version 14.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing hidden toast show more toasts than maxOpened allows
2 participants