Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirements file #528

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Add requirements file #528

merged 1 commit into from
Mar 31, 2021

Conversation

ivirshup
Copy link
Member

Testing to see if we can restore the Packages info for the project by adding the requirements.txt back.

@ivirshup ivirshup merged commit dad9a08 into scverse:master Mar 31, 2021
@flying-sheep
Copy link
Member

flying-sheep commented Mar 31, 2021

You forgot to add a test that makes sure the requirements aren’t out of sync as we decided.

Also missing: A fat header # DO NOT EDIT: THIS FILE IS AUTOGENERATED BY ...

Finally, this is dependabot/dependabot-core#3290 so we should also reference that.

@ivirshup
Copy link
Member Author

I want to see if it actually fixes the problem before adding a task to generate it/ make sure it's up to date

@flying-sheep
Copy link
Member

too bad one has to commit to master for this, but I understand

@ivirshup
Copy link
Member Author

ivirshup commented Apr 1, 2021

Dependencies of our package seem to be back (if a little strange), but dependents are not. I wonder if making a release will trigger that again. It's not obvious to me if Dependabot is even what's being used here. Sadly, got no feedback on the support forum: https://git.luolix.topmunity/t/projects-not-listing-dependencies-anymore/168530

@flying-sheep
Copy link
Member

Yeah, I’m not even sure if GitHub’s aquiring of depandabot means that anything fixed there ends up in GitHub, or if there’s still an independent version …

But I guess that’s what the OSS world gets for deciding for closed source infrastructure …

@flying-sheep
Copy link
Member

How is it autogenerated? Did you add the test checking if the file is synced?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants