-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyqt scatter widget #270
pyqt scatter widget #270
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…tialdata into kmk-scatter-pg
for more information, see https://pre-commit.ci
…tialdata into kmk-scatter-pg
for more information, see https://pre-commit.ci
The notebooks start with the instruction:
However, following this instruction and starting napari (or scatter widget) will give an error |
To do:
There were some "next steps"/"open points" here. I moved them to this issue #333 to make them more discoverable. |
There were some "next steps"/"open points" here. I moved them to this issue #333 to make them more discoverable. |
for more information, see https://pre-commit.ci
…tialdata into kmk-scatter-pg
Thanks @fjorka and @melonora, we finished reviewing and adjusting some last open points, and now we are good to merge! Really excited to ultimately release this! We will include this PR in a release X.com post that we will make in the near future. I will consolidate the points open for follow up PRs in a separate issue. |
@fjorka @melonora I forgot about this file https://github.com/fjorka/napari-spatialdata/blob/7d60e030aff750ee08fd874b8c6b6425ec5fff79/tests/test_aaa.py, which if I got it right, was a work-in-progress implementation for an alternative approach to span the test napari viewer, in order to avoid the segfault problem with Python 3.9. I think the problem have disappeared due to having dropped the Python 3.9 support. So please @melonora in the follow up PR can you drop that file? Thanks. |
Description
This PR introduces a complete Scatter Widget based on PyQtGraph, intended to replace the Matplotlib-based Scatter Widget.
Rationale
Functionality
Next Steps Beyond This PR
There were some "next steps"/"open points" here. I moved them to this issue #333 to make them more discoverable.