Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Simplify read function and datasets calls #15

Merged
merged 6 commits into from
Aug 8, 2022
Merged

Conversation

sunnyosun
Copy link
Collaborator

@sunnyosun sunnyosun commented Aug 7, 2022

  • Updated example datasets call in tutorials
  • Simplified read_fcs

Tests won't pass if docs directories are empty, so I added back the placeholder notebooks in notes, guides and examples.

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

@github-actions github-actions bot temporarily deployed to pull request August 7, 2022 13:49 Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #15 (f2cacd2) into main (9dcac41) will decrease coverage by 0.66%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   72.93%   72.27%   -0.67%     
==========================================
  Files           8        8              
  Lines         351      339      -12     
==========================================
- Hits          256      245      -11     
+ Misses         95       94       -1     
Impacted Files Coverage Δ
pytometry/read_write/_readfcs.py 100.00% <100.00%> (+6.25%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sunnyosun sunnyosun requested a review from mbuttner August 7, 2022 13:55
Copy link
Collaborator

@mbuttner mbuttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mbuttner mbuttner merged commit b81eb6e into main Aug 8, 2022
@mbuttner mbuttner deleted the simplify_read branch August 8, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants