Switch to ruff #2514
Merged
Switch to ruff #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2514 +/- ##
=======================================
Coverage 71.89% 71.89%
=======================================
Files 98 98
Lines 11518 11518
=======================================
Hits 8281 8281
Misses 3237 3237 |
flying-sheep
commented
Jun 16, 2023
Comment on lines
-165
to
-170
| line-length = 88 | ||
| target-version = ["py38"] | ||
| skip-string-normalization = true | ||
| exclude = """ | ||
| /build/.* | ||
| """ |
There was a problem hiding this comment.
line-length = 88is defaulttarget-versionis inferred fromrequires-pythonexcludeis derived from .gitignore
| /build/.* | ||
| """ | ||
|
|
||
| [tool.ruff] |
There was a problem hiding this comment.
- no
exclude, the default contains all we need - no
line-length, the default is 88 - don’t mention all the black-incompatible rules
- remove the “
F811Redefinition of unused name” from per-file ignores, as it wasn’t triggered - demote the “
E731Do not assign a lambda expression” to a per-file ignore, as it’s only used there
|
pre-commit.ci autofix |
Zethson
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2513
Compare scverse/anndata#891 and scverse/anndata@14e0cd4 (sorry for accidentally pushing to main)