Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: read header of "tissue_positions.csv" #2743

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

senbaikang
Copy link
Contributor

@senbaikang senbaikang commented Nov 9, 2023

  • Release notes not necessary because: the related code has not been released by scanpy

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #2743 (a16373d) into master (8369414) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2743   +/-   ##
=======================================
  Coverage   72.92%   72.92%           
=======================================
  Files         111      111           
  Lines       12134    12134           
=======================================
  Hits         8849     8849           
  Misses       3285     3285           
Files Coverage Δ
scanpy/readwrite.py 67.95% <ø> (ø)

@flying-sheep
Copy link
Member

Please provide context, ideally link an issue that describes the problem. Then in here, describe why your change fixes it.

@senbaikang
Copy link
Contributor Author

Hi @flying-sheep, thank you for the reply. I have created an issue #2746 and described the problem there. I find that this issue has been mentioned before, but for some reason it was not fixed right away.

@flying-sheep flying-sheep modified the milestones: 1.9.7, 1.10.0 Nov 10, 2023
@flying-sheep
Copy link
Member

Great! And indeed, it hasn’t been released yet, so if you don’t want one, we don’t need a release note.

@flying-sheep flying-sheep merged commit 786f4c5 into scverse:master Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The compatibility with SpaceRanger v2.0 or later of read_visium function
2 participants