Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to inform how to use this fork with go modules #4

Closed
rkuska opened this issue Jan 7, 2019 · 4 comments
Closed

Update README to inform how to use this fork with go modules #4

rkuska opened this issue Jan 7, 2019 · 4 comments

Comments

@rkuska
Copy link

rkuska commented Jan 7, 2019

I deleted the template as I think it is not applicable for this issue.

Currently README is missing an information about how to install the package with the recent addition of golang - Go modules.

To replace the original package it is needed to run following command:

go mod edit -replace=github.com/gocql/gocql=github.com/scylladb/gocql@v0.0.0-20181030092923-435701b4f3c0

I tried it with my fork (as I couldn't manage to load replaced module with delve):

Added a dumb debug print:
rkuska@998fd40
Replaced gocql/gocql:
go mod edit -replace=github.com/gocql/gocql=github.com/rkuska/gocql@v0.0.0-20190107194402-998fd40d125b
Run my module and show the debug print test in the output

I am happy to contribute with a patch to update the README to reflect this. Well unless I am wrong :-)

@rkuska rkuska changed the title Update README to inform how to use package with go modules Update README to inform how to use this fork with go modules Jan 7, 2019
@mmatczuk
Copy link

mmatczuk commented Jan 8, 2019

go mod edit -replace looks like a right thing to do.

@mmatczuk
Copy link

mmatczuk commented Jan 8, 2019

Thanks.

@mmatczuk
Copy link

Hi @rkuska any chances for the patch?

@rkuska
Copy link
Author

rkuska commented Jan 19, 2019 via email

rkuska added a commit to rkuska/gocql that referenced this issue Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants