Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github actions: run integration test on cassandra #339

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

github actions: run integration test on cassandra #339

wants to merge 2 commits into from

Conversation

fruch
Copy link

@fruch fruch commented Jun 24, 2024

to make sure we don't break compitability completly with cassandra introducing tests with one version of cassandra as well

@fruch fruch force-pushed the integration_test_cassandra branch from 4a5dea2 to 7aeeef4 Compare June 24, 2024 21:55
@fruch
Copy link
Author

fruch commented Jul 4, 2024

we need to skip the serverless tests, cause they are scylla specific

@fruch fruch force-pushed the integration_test_cassandra branch from 7aeeef4 to ac140e1 Compare July 4, 2024 10:41
mykaul
mykaul reviewed Jul 4, 2024
View reviewed changes
tests/integration/__init__.py
'user_defined_functions_enabled': True,
'scripted_user_defined_functions_enabled': True,
'materialized_views_enabled': True,
'sasi_indexes_enabled': True,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to enable sasi_indexes_enabled ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a clue, it's just same as the driver test was doing before for configuring cassandra, but in a new syntax.

@fruch
Copy link
Author

fruch commented Jul 4, 2024

here's the failing tests:

2024-07-04T11:52:49.6219047Z FAILED tests/integration/standard/test_custom_protocol_handler.py::CustomProtocolHandlerTest::test_protocol_divergence_v5_fail_by_continuous_paging - Failed: Unexpected success
2024-07-04T11:52:49.6219804Z FAILED tests/integration/standard/test_custom_protocol_handler.py::CustomProtocolHandlerTest::test_protocol_divergence_v5_fail_by_flag_uses_int - Failed: Unexpected success
2024-07-04T11:52:49.6220556Z FAILED tests/integration/standard/test_custom_protocol_handler.py::CustomProtocolHandlerTest::test_protocol_v5_uses_flag_int - Failed: Unexpected success
2024-07-04T11:52:49.6221541Z FAILED tests/integration/standard/test_ip_change.py::TestIpAddressChange::test_change_address_during_live_session - ccmlib.node.TimeoutError: 04 Jul 2024 11:34:19 [node3] Missing: ['Starting listening for CQL clients']:
2024-07-04T11:52:49.6221750Z INFO  [main] 2024-07-04 11:24:20,202 YamlConfigura.....
2024-07-04T11:52:49.6221851Z See system.log for remainder
2024-07-04T11:52:49.6222250Z FAILED tests/integration/standard/test_metadata.py::TestCodeCoverage::test_case_sensitivity
2024-07-04T11:52:49.6222548Z FAILED tests/integration/standard/test_metadata.py::TestCodeCoverage::test_replicas
2024-07-04T11:52:49.6223767Z FAILED tests/integration/standard/test_rate_limit_exceeded.py::TestRateLimitExceededException::test_rate_limit_exceeded - cassandra.protocol.SyntaxException: <Error from server: code=2000 [Syntax error in CQL query] message="Unknown property 'per_partition_rate_limit'">
2024-07-04T11:52:49.6226136Z FAILED tests/integration/standard/test_types.py::TypeTests::test_insert_collection_with_null_fails - cassandra.cluster.NoHostAvailable: ('Unable to complete the operation against any hosts', {<Host: 127.0.0.2:9042 dc1>: <Error from server: code=0000 [Server error] message="java.lang.NullPointerException">, <Host: 127.0.0.3:9042 dc1>: <Error from server: code=0000 [Server error] message="java.lang.NullPointerException">, <Host: 127.0.0.1:9042 dc1>: <Error from server: code=0000 [Server error] message="java.lang.NullPointerException">})
  • test_rate_limit_exceeded : should be scylla only
  • test_custom_protocol_handler: seems like they are now passing (guessing we are missing updates from upstream about that)
  • test_ip_change: using scylla specific command line arguments
  • test_metadata.py::TestCodeCoverage::test_replicas :test_case_sensitivity : not clear what's the failure maybe xfail ?

@fruch fruch force-pushed the integration_test_cassandra branch 3 times, most recently from fe5d19e to 83dcd61 Compare July 7, 2024 09:27
@fruch fruch mentioned this pull request Jul 9, 2024
Closed
@fruch fruch force-pushed the integration_test_cassandra branch 2 times, most recently from 6343573 to c68f40c Compare November 6, 2024 11:10
@fruch
Copy link
Author

fruch commented Nov 6, 2024

last failures on cassandra runs:

FAILED tests/integration/standard/test_cluster.py::ClusterTests::test_refresh_schema_no_wait - cassandra.DriverException: Schema metadata was not refreshed. See log for details.
FAILED tests/integration/standard/test_metadata.py::MetadataTimeoutTest::test_timeout - AssertionError: query `SELECT * FROM system.peers_v2` does not contain `USING TIMEOUT 2000ms`

@fruch
github actions: run integration test on cassandra
b957c0f 
to make sure we don't break compitability completly with cassandra
introducing tests with one version of cassandra as well
@fruch
tests: mark test which are scylla specific
99a37c9 
those test can't be run ontop of cassandra
and we should mark them in a why we can skip them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykaul mykaul mykaul left review comments

@roydahan roydahan roydahan approved these changes

Assignees

@dkropachev dkropachev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fruch @mykaul @roydahan @dkropachev