Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: build with manylinux_2_28 #342

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

fruch
Copy link

@fruch fruch commented Jul 1, 2024

since centos7 is EOL, and it's mirrors now broken
we are switching to newer manylinux version

Ref: pypa/cibuildwheel#1772
Ref: pypa/manylinux#1641

@fruch fruch force-pushed the build_on_manylinux_2_28 branch 3 times, most recently from 42574f3 to a032cbb Compare July 1, 2024 13:12
since centos7 is EOL, and it's mirrors now broken
we are switching to newer manylinux version

Ref: pypa/cibuildwheel#1772
Ref: pypa/manylinux#1641
@fruch fruch force-pushed the build_on_manylinux_2_28 branch from a032cbb to d631e2f Compare July 1, 2024 13:16
we don't have manylinux for those anymore,
and probably very little usage
@fruch fruch force-pushed the build_on_manylinux_2_28 branch from 2382c15 to 44f012c Compare July 1, 2024 17:47
@fruch fruch requested a review from Lorak-mmk July 1, 2024 17:49
@fruch
Copy link
Author

fruch commented Jul 1, 2024

@Lorak-mmk seems like this is fixing the issue we have with building wheels,
but with the price of dropping 32bit

I don't have a way to check specific usage like that in pypi, but I would think it's quite rare for anything to be using those nowadays

we can't release with fix this.

@Lorak-mmk
Copy link

@Lorak-mmk seems like this is fixing the issue we have with building wheels, but with the price of dropping 32bit

I don't have a way to check specific usage like that in pypi, but I would think it's quite rare for anything to be using those nowadays

I don't think we need to care about 32 bit.

we can't release with fix this.

I don't understand this sentence.

@fruch
Copy link
Author

fruch commented Jul 1, 2024

@Lorak-mmk seems like this is fixing the issue we have with building wheels, but with the price of dropping 32bit
I don't have a way to check specific usage like that in pypi, but I would think it's quite rare for anything to be using those nowadays

I don't think we need to care about 32 bit.

we can't release with fix this.

I don't understand this sentence.

we can't release any version, without this fix.

@fruch
Copy link
Author

fruch commented Jul 2, 2024

o.k. so bye bye 32bit wheels !!!

@fruch fruch merged commit af1cbb8 into scylladb:master Jul 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants