Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: download libev via conan, for windows builds to have it #344

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

fruch
Copy link

@fruch fruch commented Jul 2, 2024

windows builds so far was running with having libev available and until this sync the fallback for python 3.12 was asyncio eventloop, but now we fail and not fall back to asyncio. so all unittest on windows are failing on any import from cassandra.connection.

in this change we use conan to download libev, and using it to compile the driver with libev

Ref: https://conan.io/center/recipes/libev

windows builds so far was running with having libev available
and until this sync the fallback for python 3.12 was asyncio
eventloop, but now we fail and not fall back to asyncio.
so all unittest on windows are failing on any import from
cassandra.connection.

in this change we use conan to download libev, and using
it to compile the driver with libev

Ref: https://conan.io/center/recipes/libev
@fruch
Copy link
Author

fruch commented Jul 4, 2024

@Lorak-mmk I'm merging this
I've tested it enough during the work on sync with upstream.

and it was one reason of dropping the 32bit (but the windows one)

@fruch fruch merged commit 8a4387a into scylladb:master Jul 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant