-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(is_port_used): make it more robust #8046
Conversation
This reverts commit d5176a3.
Previous fix for verifying port down was not sufficient as still docker case was failing sometimes - despite port was not used `is_port_used` method was showing otherwise. Reverted it and replaced logic for `is_port_used` method to try establish connection with python. fixes: scylladb#8031
Still has the concern of generating warning in scylla log |
I didn't notice warnings related to this. In ScyllaKillMonkey warnings relate to lost connections between nodes. |
in docker artifact test, we can now see that node startup takes ~8.5s while without this fix was ~4s (and was premature - as cql port was not up yet). extract from log (see, it waits properly with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reverted previous fix for wait_db_down - it was working for checking db down properly, but still
is_port_used
was not working right for docker backend.So used this new working approach in
is_port_used
instead.fixes: #8031
Testing
PR pre-checks (self review)
backport
labelsReminders
sdcm/sct_config.py
)unit-test/
folder)