Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport perf-v15] fix(jmx): fix wait for jmx up #8203

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 30, 2024

As we now verify ports being open from sct runner, we cannot use it for jmx as it listens on localhost.

Fix by verifying JMX being up by verification of log message in scylla-jmx service status.

fixes: #8183

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

(cherry picked from commit abc641b)

Parent PR: #8190

As we now verify ports being open from sct runner, we cannot use it for
jmx as it listens on localhost.

Fix by verifying JMX being up by verification of log message in
scylla-jmx service status.

fixes: #8183
(cherry picked from commit abc641b)
@mergify mergify bot assigned soyacz Jul 30, 2024
Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch merged commit 21b25c5 into branch-perf-v15 Jul 30, 2024
7 checks passed
@mergify mergify bot deleted the mergify/bp/branch-perf-v15/pr-8190 branch July 30, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants