Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use streaming instead of RBNO for a few longevity tests #8402

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Aug 19, 2024

Overview

  • Use streaming for one tier1 (longevity-mv-si-4days) and one tier2 (longevity-cdc-8h-multi-dc-topology-changes) longevity tests

Testing

  • Run longevity-mv-si-4days in jenkins
  • Run longevity-cdc-8h-multi-dc-topology-changes in jenkins

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Questions

  • Are those two tests enough? Should I add more tests from different categories?
    • Are those even right tests?
  • How can I verify that it uses streaming?
  • For how long do I need to run tests to verify correctness of this PR?

Fixes #8289

@pehala pehala added the backport/2024.2 Need backport to 2024.2 label Aug 19, 2024
@roydahan
Copy link
Contributor

I'm not in favor of the renaming, it helps to have the history in one place.
If we do that renaming to make it clear that this one uses streaming, maybe it would be better to duplicate these and just replace the ones we have in in tier1 with them.
(i.e. move the originals to "longevity" and put the new ones in tier1, tier2).

@fruch
Copy link
Contributor

fruch commented Aug 28, 2024

I'm not in favor of the renaming, it helps to have the history in one place. If we do that renaming to make it clear that this one uses streaming, maybe it would be better to duplicate these and just replace the ones we have in in tier1 with them. (i.e. move the originals to "longevity" and put the new ones in tier1, tier2).

also we should add the new jobs into the tier1/teir2 triggers while we add them

…nges.jenkinsfile

Rename to longevity-cdc-8h-multi-dc-topology-changes-streaming.jenkinsfile
Move old version to longevity/longevity-cdc-8h-multi-dc-topology-changes.jenkinsfile

-
Rename to longevity-mv-si-4days-streaming.jenkinsfile
Move old version to longevity/longevity-mv-si-4days.jenkinsfile
@pehala
Copy link
Contributor Author

pehala commented Sep 3, 2024

  • Move old tests to longevity
  • Change triggers to use new tests

@pehala pehala marked this pull request as ready for review September 3, 2024 10:39
Copy link
Contributor

@roydahan roydahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch
Copy link
Contributor

fruch commented Sep 11, 2024

@pehala

A general comment, if you run any Jenkins jobs, please supply link to them or to Argus, so whom need would be able to cross check what was running

@fruch fruch merged commit d722f0d into scylladb:master Sep 11, 2024
7 checks passed
@fruch
Copy link
Contributor

fruch commented Sep 11, 2024

@roydahan @pehala

Do we want to change the triggers for release 2024.1 as well ?

@scylladbbot scylladbbot added backport/2024.2-done Commit backported to 2024.2 and removed backport/2024.2 Need backport to 2024.2 labels Sep 11, 2024
@roydahan
Copy link
Contributor

Preferably yes, assuming we tested them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test node operations with streaming (NOT with RBNO)
4 participants