Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(performance): rename new gradual test #8821

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix(performance): rename new gradual test #8821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...lla-gradual-throughput-vnodes.jenkinsfile → ...fined-throughput-steps-vnodes.jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ def lib = library identifier: 'sct@snapshot', retriever: legacySCM(scm)
perfRegressionParallelPipeline(
backend: "aws",
aws_region: "us-east-1",
test_name: "performance_regression_gradual_grow_throughput.PerformanceRegressionGradualGrowThroughputTest",
test_config: '''["test-cases/performance/perf-regression-gradual-throughput.yaml", "configurations/performance/cassandra_stress_gradual_load_steps_enterprise.yaml", "configurations/disable_kms.yaml", "configurations/tablets_disabled.yaml", "configurations/disable_speculative_retry.yaml"]''',
test_name: "performance_regression_gradual_grow_throughput.PerformanceRegressionPredefinedStepsTest",
test_config: '''["test-cases/performance/perf-regression-predefined-throughput-steps.yaml", "configurations/performance/cassandra_stress_gradual_load_steps_enterprise.yaml", "configurations/disable_kms.yaml", "configurations/tablets_disabled.yaml", "configurations/disable_speculative_retry.yaml"]''',
sub_tests: ["test_write_gradual_increase_load", "test_read_gradual_increase_load", "test_mixed_gradual_increase_load"],
)
4 changes: 2 additions & 2 deletions ...lla-gradual-throughput-vnodes.jenkinsfile → ...fined-throughput-steps-vnodes.jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ def lib = library identifier: 'sct@snapshot', retriever: legacySCM(scm)
perfRegressionParallelPipeline(
backend: "aws",
aws_region: "us-east-1",
test_name: "performance_regression_gradual_grow_throughput.PerformanceRegressionGradualGrowThroughputTest",
test_config: '''["test-cases/performance/perf-regression-gradual-throughput.yaml", "configurations/performance/cassandra_stress_gradual_load_steps.yaml", "configurations/disable_kms.yaml", "configurations/tablets_disabled.yaml", "configurations/disable_speculative_retry.yaml"]''',
test_name: "performance_regression_gradual_grow_throughput.PerformanceRegressionPredefinedStepsTest",
test_config: '''["test-cases/performance/perf-regression-predefined-throughput-steps.yaml", "configurations/performance/cassandra_stress_gradual_load_steps.yaml", "configurations/disable_kms.yaml", "configurations/tablets_disabled.yaml", "configurations/disable_speculative_retry.yaml"]''',
sub_tests: ["test_write_gradual_increase_load", "test_read_gradual_increase_load", "test_mixed_gradual_increase_load"],
)
2 changes: 1 addition & 1 deletion ...lines/performance/branch-perf-v15/scylla-master/weekly-enterprise-performance-trigger.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ provision_type=on_demand</properties>
<textParamValueOnNewLine>false</textParamValueOnNewLine>
</hudson.plugins.parameterizedtrigger.PredefinedBuildParameters>
</configs>
<projects>../scylla-enterprise/perf-regression/scylla-enterprise-perf-regression-scylla-gradual-throughput-grow-2.3gb,../scylla-enterprise/perf-regression/scylla-enterprise-perf-regression-latency-shard-aware-1TB,../scylla-enterprise/perf-regression/scylla-enterprise-perf-regression-latency-650gb-with-nemesis,../scylla-enterprise/perf-regression/scylla-enterprise-perf-regression-throughput-shard-aware-i4i</projects>
<projects>../scylla-enterprise/perf-regression/scylla-enterprise-perf-regression-predefined-throughput-steps-vnodes,../scylla-enterprise/perf-regression/scylla-enterprise-perf-regression-latency-shard-aware-1TB,../scylla-enterprise/perf-regression/scylla-enterprise-perf-regression-latency-650gb-with-nemesis,../scylla-enterprise/perf-regression/scylla-enterprise-perf-regression-throughput-shard-aware-i4i</projects>
<condition>SUCCESS</condition>
<triggerWithNoParameters>false</triggerWithNoParameters>
<triggerFromChildProjects>false</triggerFromChildProjects>
Expand Down
4 changes: 2 additions & 2 deletions ...lla-gradual-throughput-vnodes.jenkinsfile → ...fined-throughput-steps-vnodes.jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ def lib = library identifier: 'sct@snapshot', retriever: legacySCM(scm)
perfRegressionParallelPipeline(
backend: "aws",
aws_region: "us-east-1",
test_name: "performance_regression_gradual_grow_throughput.PerformanceRegressionGradualGrowThroughputTest",
test_config: '''["test-cases/performance/perf-regression-gradual-throughput.yaml", "configurations/performance/cassandra_stress_gradual_load_steps.yaml", "configurations/disable_kms.yaml", "configurations/tablets_disabled.yaml", "configurations/disable_speculative_retry.yaml"]''',
test_name: "performance_regression_gradual_grow_throughput.PerformanceRegressionPredefinedStepsTest",
test_config: '''["test-cases/performance/perf-regression-predefined-throughput-steps.yaml", "configurations/performance/cassandra_stress_gradual_load_steps.yaml", "configurations/disable_kms.yaml", "configurations/tablets_disabled.yaml", "configurations/disable_speculative_retry.yaml"]''',
sub_tests: ["test_write_gradual_increase_load", "test_read_gradual_increase_load", "test_mixed_gradual_increase_load"],

timeout: [time: 1600, unit: "MINUTES"]
Expand Down
6 changes: 3 additions & 3 deletions performance_regression_gradual_grow_throughput.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from performance_regression_test import PerformanceRegressionTest
from sdcm.sct_events import Severity
from sdcm.sct_events.system import TestFrameworkEvent
from sdcm.results_analyze import ThroughputLatencyGradualGrowPayloadPerformanceAnalyzer
from sdcm.results_analyze import PredefinedStepsTestPerformanceAnalyzer
from sdcm.utils.decorators import latency_calculator_decorator
from sdcm.utils.latency import calculate_latency, analyze_hdr_percentiles

Expand All @@ -18,7 +18,7 @@ class CSPopulateDistribution(Enum):
UNIFORM = "uniform"


class PerformanceRegressionGradualGrowThroughputTest(PerformanceRegressionTest): # pylint: disable=too-many-instance-attributes
class PerformanceRegressionPredefinedStepsTest(PerformanceRegressionTest): # pylint: disable=too-many-instance-attributes
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
# all parameters were taken from scylla-stress-orch repo
Expand Down Expand Up @@ -202,7 +202,7 @@ def run_gradual_increase_load(self, stress_cmd_templ, stress_num, num_loaders, c
"job_url": os.environ.get("BUILD_URL"),
"shard_aware_driver": self.is_shard_awareness_driver,
}
perf_analyzer = ThroughputLatencyGradualGrowPayloadPerformanceAnalyzer(
perf_analyzer = PredefinedStepsTestPerformanceAnalyzer(
es_index=self._test_index,
es_doc_type=self._es_doc_type,
email_recipients=self.params.get('email_recipients'))
Expand Down
0 ...ults_incremental_throughput_increase.html → ...results_performance_predefined_steps.html
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions sdcm/results_analyze/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1507,15 +1507,15 @@ def check_regression_multi_baseline( # noqa: PLR0912, PLR0914, PLR0915
self.save_email_data_file(subject, email_data, file_path='email_data.json')


class ThroughputLatencyGradualGrowPayloadPerformanceAnalyzer(LatencyDuringOperationsPerformanceAnalyzer):
class PredefinedStepsTestPerformanceAnalyzer(LatencyDuringOperationsPerformanceAnalyzer):
"""
Performance Analyzer for results with throughput and latency of gradual payload increase
"""

def __init__(self, es_index, es_doc_type, email_recipients=(), logger=None, events=None): # pylint: disable=too-many-arguments
super().__init__(es_index=es_index, es_doc_type=es_doc_type, email_recipients=email_recipients,
logger=logger, events=events)
self._email_template_fp = "results_incremental_throughput_increase.html"
self._email_template_fp = "results_performance_predefined_steps.html"
self.percentiles = ['percentile_95', 'percentile_99']

def _test_stats(self, test_doc):
Expand Down Expand Up @@ -1560,7 +1560,7 @@ def prepare_attachment_files_for_email(self, results):
template_file='results_reactor_stall_events_list.html'),
self.save_html_to_file(results,
file_name='full_email_report.html',
template_file='results_incremental_throughput_increase.html'),
template_file='results_performance_predefined_steps.html'),
]


Expand Down
2 changes: 1 addition & 1 deletion ...e/perf-regression-gradual-throughput.yaml → ...gression-predefined-throughput-steps.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ use_capacity_reservation: true

use_preinstalled_scylla: true

user_prefix: 'perf-regression-gradual'
user_prefix: 'perf-regression-predefined-steps'

backtrace_decoding: false
print_kernel_callstack: true
Expand Down