Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana renderer #1062

Merged
merged 3 commits into from
Sep 22, 2020
Merged

Grafana renderer #1062

merged 3 commits into from
Sep 22, 2020

Conversation

amnonh
Copy link
Collaborator

@amnonh amnonh commented Sep 22, 2020

The grafana renderer is an extension that allows a user to download capture of a dashboard.
When I tested it, it run very slow, so I'm not sure how useful it will be.

This series adds it as an optional, by running start-all.sh with -E.

Fixes #904

@amnonh
Copy link
Collaborator Author

amnonh commented Sep 22, 2020

@fruch I'm adding it as an option, can you take it for a spin?

@amnonh amnonh requested a review from fruch September 22, 2020 14:38
@fruch
Copy link
Contributor

fruch commented Sep 22, 2020

@fruch I'm adding it as an option, can you take it for a spin?

I can confirm it's working, and taking ~30sec for a full dashboard, it's a lot, spining up chrome with webdriver take much more time then that (when it works)

@amnonh amnonh merged commit 59421b0 into scylladb:master Sep 22, 2020
@amnonh amnonh deleted the grafana_renderer branch September 22, 2020 16:50
@bentsi
Copy link

bentsi commented Sep 22, 2020

@amnonh are you planning to include this in the next Scylla Monitoring release?

@tzach
Copy link
Contributor

tzach commented Sep 22, 2020

@amnonh we need to move away from startup options to cloud oriented work.
Scylla Cloud users can not control these option, so we need to decide if we want to include it or not.

@fruch
Copy link
Contributor

fruch commented Sep 22, 2020

@tzach, I think it's o.k. to gather some feedback first, then we see it's working good, enable it by default.

@roydahan
Copy link
Contributor

I agree with @fruch.
And yes, 30s is long but better than what we have now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a grafana-image-renderer to scylla-monitoring
5 participants