Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workouround for controler-gen interpreting numbers in file paths #1646

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Fix workouround for controler-gen interpreting numbers in file paths #1646

merged 1 commit into from
Dec 18, 2023

Conversation

tnozicka
Copy link
Member

Description of your changes:
This PR avoids creating temporary directories that could be interpreted as a number by controller-gen. See kubernetes-sigs/controller-tools#734

$ go run ./vendor/sigs.k8s.io/controller-tools/cmd/controller-gen -- crd paths='./pkg/api/scylla/v1' output:dir='/tmp/crd-2P4zCT/generated/./pkg/api/scylla/v1'
Error: unable to parse option "output:dir=/tmp/crd-2P4zCT/generated/./pkg/api/scylla/v1": ['P' exponent requires hexadecimal mantissa (at <input>:1:10)]

Which issue is resolved by this Pull Request:
Resolves #1546

@tnozicka tnozicka added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. labels Dec 18, 2023
@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2023
rzetelskik
rzetelskik approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2023
@scylla-operator-bot scylla-operator-bot bot merged commit df40b6e into scylladb:master Dec 18, 2023
10 of 11 checks passed
@tnozicka tnozicka deleted the fix-mktemp branch December 18, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzetelskik rzetelskik rzetelskik approved these changes

@zimnx zimnx Awaiting requested review from zimnx

Assignees

@rzetelskik rzetelskik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Flake] controller-gen: unable to parse option
2 participants
@tnozicka @rzetelskik