Skip to content

Commit

Permalink
CI: adjust the workflows for the new "chrono" and "time" features
Browse files Browse the repository at this point in the history
The definitions of GitHub workflow files for Scylla and Cassandra tests
are adjusted so that:

- We check that the code compiles with and without serialization
  features,
- All serialization features are enabled when Scylla/Cassandra tests are
  running.
  • Loading branch information
piodul committed Sep 27, 2023
1 parent 99d6792 commit e7b7de2
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/cassandra.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ jobs:
docker compose -f test/cluster/cassandra/docker-compose.yml up -d --wait
# A separate step for building to separate measuring time of compilation and testing
- name: Build the project
run: cargo build --verbose --tests
run: cargo build --verbose --tests --features "full-serialization"
- name: Run tests on cassandra
run: |
CDC='disabled' SCYLLA_URI=172.42.0.2:9042 SCYLLA_URI2=172.42.0.3:9042 SCYLLA_URI3=172.42.0.4:9042 cargo test --verbose -- --skip test_views_in_schema_info
CDC='disabled' SCYLLA_URI=172.42.0.2:9042 SCYLLA_URI2=172.42.0.3:9042 SCYLLA_URI3=172.42.0.4:9042 cargo test --verbose --features "full-serialization" -- --skip test_views_in_schema_info
- name: Stop the cluster
if: ${{ always() }}
run: docker compose -f test/cluster/cassandra/docker-compose.yml stop
Expand Down
22 changes: 11 additions & 11 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,16 @@ jobs:
run: cargo fmt --verbose --all -- --check
- name: Clippy check
run: cargo clippy --verbose --examples --tests -- -Aclippy::uninlined_format_args
- name: Cargo check without features
run: cargo check --manifest-path "scylla/Cargo.toml" --features ""
- name: Cargo check with secrecy feature
run: cargo check --manifest-path "scylla/Cargo.toml" --features "secret"
- name: Cargo check without serialization features
run: cargo check --manifest-path "scylla/Cargo.toml"
- name: Cargo check with all serialization features
run: cargo check --manifest-path "scylla/Cargo.toml" --features "full-serialization"
- name: Build scylla-cql
run: cargo build --verbose --all-targets --manifest-path "scylla-cql/Cargo.toml"
run: cargo build --verbose --all-targets --manifest-path "scylla-cql/Cargo.toml" --features "full-serialization"
- name: Build
run: cargo build --verbose --examples
run: cargo build --verbose --examples --features "full-serialization"
- name: Run tests
run: SCYLLA_URI=172.42.0.2:9042 SCYLLA_URI2=172.42.0.3:9042 SCYLLA_URI3=172.42.0.4:9042 cargo test --verbose
run: SCYLLA_URI=172.42.0.2:9042 SCYLLA_URI2=172.42.0.3:9042 SCYLLA_URI3=172.42.0.4:9042 cargo test --verbose --features "full-serialization"
- name: Stop the cluster
if: ${{ always() }}
run: docker compose -f test/cluster/docker-compose.yml stop
Expand All @@ -56,10 +56,10 @@ jobs:
rustup override set ${{ env.rust_min }}
- name: Print Rust version
run: rustc --version
- name: MSRV cargo check with features
run: cargo check --verbose --examples --tests
- name: MSRV cargo check without features
run: cargo check --verbose --manifest-path "scylla/Cargo.toml"
- name: MSRV cargo check with all features
run: cargo check --verbose --all-targets --all-features
- name: MSRV cargo check scylla without features
run: cargo check --verbose --all-targets --manifest-path "scylla/Cargo.toml"
- name: MSRV cargo check scylla-cql
run: cargo check --verbose --all-targets --manifest-path "scylla-cql/Cargo.toml"

Expand Down

0 comments on commit e7b7de2

Please sign in to comment.