exec_profile_handle: allow public access to associated profile #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last time, I introduced getters for `ExecutionProfile`. However, I forgot that in cpp-rust-driver use case, we only have an access to `ExecutionProfileHandle`... Since, we can convert handle to builder, I see no objections against having the ability to convert it to well-defined execution profile. Obviously, we need to clone an `Arc`. But only a single one. Notice, however, that when converting to builder, we need to clone multiple Arcs anyway (e.g. retry or load balancing policies).
|
|
wprzytula
approved these changes
Oct 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last time, I introduced getters for
ExecutionProfile. However, I forgot that in cpp-rust-driver use case, we only have an access toExecutionProfileHandle...Since, we can convert handle to builder, I see no objections against having the ability to convert it to well-defined execution profile.
Obviously, we need to clone an
Arc. But only a single one. Notice, however, that when converting to builder,we need to clone multiple Arcs anyway (e.g. retry or load balancing policies).
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.