MSRV: bump to 1.66.0 #810
Merged
MSRV: bump to 1.66.0 #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of our indirect dependencies (`toml_edit`) has updated its MSRV. As we do not keep Cargo.lock committed in the repo and cargo does not honor MSRV during crate resolution, we can just bump our current MSRV by one version forward, from 1.65.0 to 1.66.0. The version 1.66.0 is over 8 months old, so it's pretty old by the MSRV-breaking standards of the community.
`unzip_option` was a workaround for missing `Option::unzip()`, which was introduced in Rust v1.66.0. We finally bumped the MSRV to 1.66.0, so `unzip_option` can be removed and replaced with the real thing.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our indirect dependencies (
toml_edit) has updated its MSRV. As we do not keep Cargo.lock committed in the repo and cargo does not honor MSRV during crate resolution, we can just bump our current MSRV by one version forward, from 1.65.0 to 1.66.0.The version 1.66.0 is over 8 months old, so it's pretty old by the MSRV-breaking standards of the community.
As a bonus, we get rid of
unzip_optionworkaround and use the real thing, i.e.Option::unzip().Pre-review checklist
[ ] I added relevant tests for new features and bug fixes.[ ] I have provided docstrings for the public items that I want to introduce.[ ] I have adjusted the documentation in./docs/source/.[ ] I added appropriateFixes:annotations to PR description.