examples/execution_profile: fix usage of illegal consistency #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example in `execution_profile.rs` tried to send a read request using consistency `EACH_QUORUM`. This doesn't work, the query failed with the following message: ``` Error: Database returned an error: The query is syntactically correct but invalid, Error message: EACH_QUORUM ConsistencyLevel is only supported for writes ``` Examples shouldn't fail. Let's fix it by changing `EachQuorum` to `LocalQuorum` which can be used in SELECTs. After this change the example doesn't fail. It still demonstrates how to create an execution profile with a custom consistency level, it doesn't matter what consistency level is used. Fixes: scylladb#835 Signed-off-by: Jan Ciolek <jan.ciolek@scylladb.com>
Lorak-mmk
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example in
execution_profile.rstried to send a read request using consistencyEACH_QUORUM.This doesn't work, the query failed with the following message:
Examples shouldn't fail. Let's fix it by changing
EachQuorumtoLocalQuorumwhich can be used in SELECTs.After this change the example doesn't fail.
It still demonstrates how to create an execution profile with a custom consistency level, it doesn't matter what consistency level is used.
Fixes: #835
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.