Makefile: build and check benches #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft until CI finished - I couldn't run it locally as I'm testing #858 |
piodul
reviewed
Dec 12, 2023
In the current makefile benchmarks are not built or checked with `cargo check` / `cargo clippy` so any errors appearing in them will not be caught locally by a dev running `make ci` to perform checks / tests. This commit adds benchmark building / checking to all relevant makefile targets.
Lorak-mmk
force-pushed
the
benches-in-ci
branch
from
a2f286c to
869c5a0
Compare
piodul
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current makefile benchmarks are not built or checked with
cargo check/cargo clippyso any errors appearing in them will not be caught locally by a dev runningmake cito perform checks / tests.This PR adds benchmark building / checking to all relevant makefile targets.
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.