Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce CqlTimeuuid type #894

Merged
merged 10 commits into from
Jan 26, 2024
Merged

Introduce CqlTimeuuid type #894

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e0c35c1
scylla-cql: introduce CqlTimeuuid type
muzarski Dec 21, 2023
71f9e7a
timeuuid: implement strong ordering on CqlTimeuuid
muzarski Dec 21, 2023
8d81a6b
timeuuid: implement Hash for CqlTimeuuid
muzarski Jan 19, 2024
abc8d28
tests: add test for timeuuid ordering properties
muzarski Jan 19, 2024
9e2ac1f
timeuuid: add missing delegate methods
muzarski Dec 21, 2023
6b870a3
timeuuid: implement fmt::Display for CqlTimeuuid
muzarski Dec 22, 2023
d11e8c3
cql: wrap CqlTimeuuid in CqlValue::Timeuuid
muzarski Dec 22, 2023
5432eba
cql: remove native timeuuid <-> uuid::Uuid mapping
muzarski Dec 22, 2023
0db6583
tests: add timeuuid runtime ordering test
muzarski Dec 22, 2023
1958216
docs: update uuid/timeuuid info
muzarski Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions scylla-cql/src/frame/value.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,13 @@ impl PartialEq for CqlTimeuuid {
}
}

impl std::hash::Hash for CqlTimeuuid {
fn hash<H: std::hash::Hasher>(&self, state: &mut H) {
self.lsb_signed().hash(state);
self.msb().hash(state);
Comment on lines +213 to +214
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the lsb_signed() and msb() do some unnecessary work - the former performs a XOR, and the latter shuffles bytes around. It would be sufficient to take the bytes as they are, AND one of the bytes (like msb() does now) and compare. Same goes for the PartialEq implementation.

These are micro-optimizations with dubious performance impact, so it's fine to implement them in a followup (or never).

}
}

/// Native CQL date representation that allows for a bigger range of dates (-262145-1-1 to 262143-12-31).
///
/// Represented as number of days since -5877641-06-23 i.e. 2^31 days before unix epoch.
Expand Down