Skip to content

Commit

Permalink
chore: use pinned npm supplied by node
Browse files Browse the repository at this point in the history
nodejs/corepack#93 (comment)

nodejs/node#50963 (comment)

nodejs/node#50963

Signed-off-by: Sebastian Davids <sdavids@gmx.de>
  • Loading branch information
sdavids committed Jan 12, 2024
1 parent 2e86b65 commit 76089b8
Show file tree
Hide file tree
Showing 4 changed files with 34 additions and 47 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ runs:
node-version-file: ${{ inputs.node-version-file }}
cache-dependency-path: ${{ inputs.dependencies-lock-file }}
cache: npm
- name: Enable Corepack
shell: bash
working-directory: ${{ inputs.working-directory }}
run: corepack enable npm
- name: Install dependencies
shell: bash
working-directory: ${{ inputs.working-directory }}
Expand Down
6 changes: 0 additions & 6 deletions TODO
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@ https://github.com/amilajack/eslint-plugin-compat/issues/603
+
https://github.com/azeemba/eslint-plugin-json/issues/80

* use official corepack support from setup-node action
+
remove 'Enable Corepack' step in setup-node-and-install-dependencies/action.yaml
+
https://github.com/actions/setup-node/issues/531

* remove body-max-line-length in commitlint.config.mjs
+
https://github.com/conventional-changelog/commitlint/issues/2112
Expand Down
67 changes: 33 additions & 34 deletions hp/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions hp/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,8 @@
"format": "scripts/format.sh",
"format:check": "scripts/format-check.sh"
},
"packageManager": "npm@10.2.5",
"engines": {
"node": ">=20.11",
"npm": ">=10"
"node": ">=20.11"
},
"devDependencies": {
"@commitlint/cli": "18.4.4",
Expand Down

0 comments on commit 76089b8

Please sign in to comment.