This repository has been archived by the owner on Feb 3, 2018. It is now read-only.
Ignore dirs/files with perms issues in ListPackages #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeformz
reviewed
Jan 28, 2017
| @@ -203,6 +223,9 @@ func fillPackage(p *build.Package) error { | |||
| for _, file := range gofiles { | |||
| pf, err := parser.ParseFile(token.NewFileSet(), file, nil, parser.ImportsOnly|parser.ParseComments) | |||
| if err != nil { | |||
| if terr, ok := err.(*os.PathError); ok && terr.Err == syscall.Errno(syscall.EACCES) { | |||
There was a problem hiding this comment.
BTW: You probably wanted to use os.IsPermission() here
There was a problem hiding this comment.
So probably ...
if err != nil {
if os.IsPermission(err) {
continue
}
return err
}There was a problem hiding this comment.
AHHHH that's what i was freakin looking for
Current coverage is 78.88% (diff: 85.71%)@@ master #163 diff @@
==========================================
Files 23 23
Lines 3653 3657 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2885 2885
- Misses 569 576 +7
+ Partials 199 196 -3
|
krisnova
pushed a commit
to krisnova/dep
that referenced
this pull request
Apr 21, 2017
Ignore dirs/files with perms issues in ListPackages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154