This repository has been archived by the owner on Feb 3, 2018. It is now read-only.
Implement tracelog #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This still has some rough edges, but is lookin fairly good. Can iron out the rough bits in a later issue. |
krisnova
pushed a commit
to krisnova/dep
that referenced
this pull request
Apr 21, 2017
Implement tracelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #5 and #15
still need to write up an alternate version of string generation for the error types that we pass in. what's done now is just too verbose for inclusion in trace tree output, but it's good when it's the final error, so we need an alternate path.