Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sdf Transport Support for v1.4.1-SNAPSHOT #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

akbog
Copy link

@akbog akbog commented Oct 24, 2023

Currently, v.1.5.0 or latest main for OpenLineage is broken for Databricks because it has (since release 1.4.1) introduced dependencies on Java 11 Libraries, which are not supported in Databricks.

This PR is off of the v1.4.1 Tag and introduces an SdfTransport, which simply writes a new file per open lineage event encountered

@akbog akbog changed the title Add Sdf Transport Support for v1.4.0-SNAPSHOT Add Sdf Transport Support for v1.4.1-SNAPSHOT Oct 24, 2023
log.info("emitted event: " + eventAsJson);
} catch (IOException | IllegalArgumentException e) {
log.error("Writing event to a file {} failed: {}", path_to_write.toString(), e);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we catch all exceptions also?

openLineageContext
.getQueryExecution()
.ifPresent(
qe ->
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this method have to be protected by try/catch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants